Introduce "plugins_data_dir" which is preserved during khepri migration #14609
Conversation
This is mainly for community plugins which want to migrate away from Mnesia into a new subdir. (They might not even use Khepri, or use Khepri but a different store id.) Fixes rabbitmq#11304
There was a problem hiding this comment.
The idea is reasonable. The name plugins_data_dir suggests that it is a directory used or maintained by RabbitMQ but it's not the case.
We need a better name. user_plugins_dir would make it immediately obvious that the directly is NOT maintained by RabbitMQ.
Or additional_plugins_dir but that's not as descriptive w.r.t. who maintains that directory (the user, not RabbitMQ).
|
thanks for looking at it and the name suggestions. Let me note that "plugins_dir" is the dir where plugin code is, while this directory is for data (from user code). what about |
|
@gomoripeti yup, after re-reading #11304 I have figured the difference and the intent. #14622 uses This contribution will ship in |
2 participants
Proposed Changes
This is mainly for community plugins which want to migrate away from Mnesia into a new subdir. (They might not even use Khepri, or use Khepri but a different store id.)
Fixes #11304
If accepted, I shall update docs for community plugin developers somewhere on https://www.rabbitmq.com/plugin-development
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.